Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: upgrade to 1.11.0 #189

Merged
merged 86 commits into from
Aug 16, 2024
Merged

chore: upgrade to 1.11.0 #189

merged 86 commits into from
Aug 16, 2024

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Aug 14, 2024 •
edited
Loading

Status: ✅ Tested on my local devnet, testnet => Block production / finalization + submit extrinsic works well.

References

Direct changes

  • [#3512]: [FRAME] Introduce Runtime Omni Bencher
  • [#2714]: GenesisConfig presets for runtime
  • [#3801]: Remove slot_duration from aura::collators::basic::Params
  • [#2292]: Migrate Fee Payment from Currency to fungible traits
  • [#4017]: Complete removal of TryRuntime subcommand

@chungquantin chungquantin mentioned this pull request Aug 14, 2024
Merged
7 tasks
al3mart
al3mart reviewed Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't have pushed back on including Litep2p. But appreaciate the prio.

Just left a comment regarding that we could add the genesis configs in the runtime with the changes coming from #2714. More as a reminder than anything else, as this might want to be done once we have finish working on the chain of upgrades.

Though, it is something I believe we want to do anyway.

Base automatically changed from chungquantin/chore-polkadot-v1.10.0 to developer August 15, 2024 15:03
peterwht
peterwht approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! Added some "nice-to-have" comments for the build.rs. You can postpone to later PRs if it's easier for git rebasing etc.

@chungquantin chungquantin mentioned this pull request Aug 16, 2024
Open
@chungquantin chungquantin requested a review from al3mart August 16, 2024 03:52
@peterwht
Copy link
Collaborator

[sc-918]

@chungquantin chungquantin merged commit 2170af7 into developer Aug 16, 2024
7 of 8 checks passed
@chungquantin chungquantin deleted the chungquantin/chore-polkadot-v1.11.0 branch August 16, 2024 08:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@al3mart al3mart al3mart approved these changes

@peterwht peterwht peterwht approved these changes

Assignees

@chungquantin chungquantin

Labels
ready-for-high-level-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chungquantin @codecov-commenter @peterwht @al3mart